HEXRD / hexrd

A cross-platform, open-source library for the analysis of X-ray diffraction data.
Other
54 stars 26 forks source link

Consolidate new transforms api #654

Closed kevindlewis23 closed 2 weeks ago

kevindlewis23 commented 2 weeks ago

Removed the xf-api decorators in xf_new_capi, as well as the transform_definitions.py file that they come from. Also removed unused implementations of transform_definitions (numpy and numba).

Pros:

Cons:

Maybe deprecate other implementations instead of deleting for now

kevindlewis23 commented 2 weeks ago

It sounds like the python stuff had a fewer newer algorithms,. It is possible people are using these, maybe deprecation makes sense?

psavery commented 2 weeks ago

I think the Python versions Oscar was talking about are scattered throughout the code. I think these are probably not being used. They didn't exist in hexrd until I copied Oscar's repo over (and I don't think users would even know about them unless they went searching through the code).

psavery commented 2 weeks ago

Since we can still retrieve these functions if we need them later, and since I think it's very unlikely they are being used by anyone, I'd so just go ahead and merge this PR. You can merge when ready.