search

HEXRD / hexrd

A cross-platform, open-source library for the analysis of X-ray diffraction data.
Other
56 stars 25 forks source link

Lint tomoutil and nfutil #678

Closed ZackAttack614 closed 2 months ago

ZackAttack614 commented 2 months ago

Mostly this cleans up the nfutil.py script. I linted the code, simplified some logic, and cut out some unnecessary commented out code and arguments. This will make it a bit easier to do a version migration to 1.0.0.

This was an aggressive update, so I am very open to requested changes before doing a full merge.

pep8speaks commented 2 months ago

Hello @ZackAttack614! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1114:80: E501 line too long (87 > 79 characters) Line 1136:80: E501 line too long (87 > 79 characters) Line 1553:80: E501 line too long (103 > 79 characters) Line 1718:29: E252 missing whitespace around parameter equals Line 1718:30: E252 missing whitespace around parameter equals Line 1738:80: E501 line too long (82 > 79 characters) Line 1807:80: E501 line too long (85 > 79 characters) Line 1815:80: E501 line too long (85 > 79 characters) Line 1836:80: E501 line too long (81 > 79 characters)

Line 122:57: E203 whitespace before ':' Line 212:32: E203 whitespace before ':' Line 212:55: E203 whitespace before ':'

Line 148:18: E225 missing whitespace around operator Line 148:69: E502 the backslash is redundant between brackets Line 152:17: E225 missing whitespace around operator Line 152:70: E231 missing whitespace after ',' Line 152:80: E501 line too long (115 > 79 characters) Line 152:84: E231 missing whitespace after ',' Line 152:95: E231 missing whitespace after ','

Comment last updated at 2024-07-11 17:31:46 UTC
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 414 lines in your changes missing coverage. Please review.

Project coverage is 30.23%. Comparing base (5ecf297) to head (2638c99).

Files Patch % Lines
hexrd/grainmap/nfutil.py 0.00% 348 Missing :warning:
hexrd/grainmap/tomoutil.py 0.00% 66 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #678 +/- ## ========================================== + Coverage 30.19% 30.23% +0.04% ========================================== Files 139 139 Lines 22236 22205 -31 ========================================== Hits 6714 6714 + Misses 15522 15491 -31 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

psavery commented 2 months ago

@gustafsonsven

ZackAttack614 commented 2 months ago

The code that this PR affects is being replaced by newer code. Marked "Won't Do."