search

HEXRD / hexrd

A cross-platform, open-source library for the analysis of X-ray diffraction data.
Other
56 stars 25 forks source link

Plane data testcases #680

Closed kevindlewis23 closed 1 month ago

kevindlewis23 commented 2 months ago

cif data from https://next-gen.materialsproject.org/, this should probably be cited somewhere, not sure where.

Also, I slightly edited one of the cif files (Ag(TeMo)6.cif), as the full space group was C12/m1, but the cif file only said 2/m and hexrd threw an error.

pep8speaks commented 2 months ago

Hello @kevindlewis23! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-07-23 14:42:36 UTC
kevindlewis23 commented 2 months ago

Note that test_with_data assumes the current implementation is correct. Also, I didn't write test cases for the methods that I was told were being deleted

kevindlewis23 commented 1 month ago

Sorry Patrick didn't mean to request another review, not sure how to cancel that

psavery commented 1 month ago

Two approvals on this one!