Open donald-e-boyce opened 3 months ago
Maybe we should just raise a NotImplementedError
if those arguments are used.
I don't think you're talking about the matrix bmat
, which uses the lattice spacing to convert HKLs to crystal components. In xy_to_gvec
, the argument rmat_b
refers to the beam reference frame, in which the 3-direction is the beam and eta
is the azimuthal angle calculated from (x, y)
and the 1-direction vector (eta = 0
). It is true the middle column is not used here.
You're right, deleted my comment
@donald-e-boyce Oscar had mentioned that there were some C functions that exist where Joel wanted to add new parameters/features, so he rewrote them in Python and added the new parameter/feature, and this resulted in an inconsistency between the C and Python versions (and the Python version would have to be used when those parameters were required).
Perhaps this is one of those cases?
The arguments
bmat
andv_inv
togvec_to_xy
are accepted but not used in thenew_capi
version of the transforms module. Thexf_numpy
also has those arguments but handles them.The
bmat
matrix converts HKLs to the components of the normal vector in the crystallographic reference frame. If this is notNone
then the inputgvec_c
are expected to be HKLs. Thev_inv
argument accounts for the grain stretch in fitting.However, I don't see any place where these arguments are actually used in calls to
gvec_to_xy
.