search

HEXRD / hexrd

A cross-platform, open-source library for the analysis of X-ray diffraction data.
Other
56 stars 25 forks source link

Potentially Broken Method - unitcell.CalcAnomalous #683

Closed ZackAttack614 closed 1 month ago

ZackAttack614 commented 1 month ago

The method unitcell.CalcAnomalous references self.f1 and self.f2, which are not defined. I suspect that this means the method isn't being used - if that isn't the case, it should be fixed.

Please advise.

psavery commented 1 month ago

@saransh13

saransh13 commented 1 month ago

Ok, yes any reference to self.CalcAnomalous has been removed ever since the introduction of the numba accelerated function heard.wppf.xtal._calcxrsf. unit cell.CalcXRFormFactor should also be removed since that is never called as well.