search

HEXRD / hexrd

A cross-platform, open-source library for the analysis of X-ray diffraction data.
Other
55 stars 26 forks source link

Potentially Broken Class Property - unitcell.Z #685

Closed ZackAttack614 closed 1 month ago

ZackAttack614 commented 1 month ago

The unitcell.Z property refers to atom_ntype, which is undefined. I believe this is meant to be self.atom_ntype, but the fact that it's been like this for many years tells me that this property is probably not used.

Should this be fixed or removed?

donald-e-boyce commented 1 month ago

Probably @saransh13 would be best to decide what to do.