This for loop in remove_duplicate_atoms appears to not be useful. It only does work on the first instance of the loop, then skips the rest.
My guess is that this is either supposed to be run with some kind of else that is missing, or this shouldn't be a for loop at all. Either way, this function is quite old and seems to me to be wrong.
psavery
commented
1 month ago
This for loop in
remove_duplicate_atomsappears to not be useful. It only does work on the first instance of the loop, then skips the rest.My guess is that this is either supposed to be run with some kind of
elsethat is missing, or this shouldn't be a for loop at all. Either way, this function is quite old and seems to me to be wrong.Should this be fixed or removed?