search

HEXRD / hexrd

A cross-platform, open-source library for the analysis of X-ray diffraction data.
Other
56 stars 25 forks source link

Rotations testcases #687

Closed kevindlewis23 closed 1 month ago

kevindlewis23 commented 1 month ago

Added some testcases for some of the math helpers in rotations.py. Also fixed quatProduct, see issue 684. After this PR confirms that the new testcases are working properly, I will rewrite some of these methods to use scipy. I didn't want to change the methods at the same time as I added the testcases, because then there is no confirmation that the new implementations work.

closes #684

pep8speaks commented 1 month ago

Hello @kevindlewis23! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-07-18 20:10:39 UTC