search

HEXRD / hexrd

A cross-platform, open-source library for the analysis of X-ray diffraction data.
Other
56 stars 25 forks source link

Remove duplicates #693

Closed kevindlewis23 closed 2 months ago

kevindlewis23 commented 3 months ago

Removal of duplicate methods and some refactoring of matrixutil. Let me know if this needs to be two separate pull requests

Also ignore the commit messages at the beginning, I'll squash these all but they are from a different branch

pep8speaks commented 3 months ago

Hello @kevindlewis23! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-07-30 14:21:59 UTC
kevindlewis23 commented 3 months ago

_buildDict in spacegroup.py has a small difference to _buildDict in symbols.py, where hstr takes everything before the colon instead of the entire string, like nstr. So, my current solution is to use the same string in both places bet let the separate buildDicts be run.

I don't know if these should be different