HEXRD / hexrd

A cross-platform, open-source library for the analysis of X-ray diffraction data.
Other
56 stars 25 forks source link

Remove scripts folder #694

Closed kevindlewis23 closed 1 month ago

kevindlewis23 commented 1 month ago

I was told "no one uses these and that they should be removed."

Check if Hydra_Feb19.yml was moved to the right place

donald-e-boyce commented 1 month ago

I would hold off on that for now ask Kelly what she thinks. I don't think the scripts are maintained and I'm not sure any actually fully work, but these are the kind of things that people may use parts of. So we should save this for discussion the next HEXRD meeting.

On Mon, Jul 29, 2024 at 12:09 PM Kevin Lewis @.***> wrote:

I was told "no one uses these and that they should be removed.

Check if Hydra_Feb19.yml was moved to the right place

You can view, comment on, or merge this pull request online at:

https://github.com/HEXRD/hexrd/pull/694 Commit Summary

File Changes

(12 files https://github.com/HEXRD/hexrd/pull/694/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/HEXRD/hexrd/pull/694, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIWT6PFJX3U42JZ4GKOIC3ZOZSMLAVCNFSM6AAAAABLUS7LC6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGQZTKOBRG4YTMMA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

kevindlewis23 commented 1 month ago

I would hold off on that for now ask Kelly what she thinks. I don't think the scripts are maintained and I'm not sure any actually fully work, but these are the kind of things that people may use parts of. So we should save this for discussion the next HEXRD meeting.

Kelly specifically said to remove it. I'll add her as a reviewer so she can document the reasoning maybe

donald-e-boyce commented 1 month ago

That's fine then!

On Mon, Jul 29, 2024 at 12:17 PM Kevin Lewis @.***> wrote:

I would hold off on that for now ask Kelly what she thinks. I don't think the scripts are maintained and I'm not sure any actually fully work, but these are the kind of things that people may use parts of. So we should save this for discussion the next HEXRD meeting.

Kelly specifically said to remove it. I'll add her as a reviewer so she can document the reasoning maybe

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

psavery commented 1 month ago

Saransh approved as well.