Closed kevindlewis23 closed 1 month ago
I would hold off on that for now ask Kelly what she thinks. I don't think the scripts are maintained and I'm not sure any actually fully work, but these are the kind of things that people may use parts of. So we should save this for discussion the next HEXRD meeting.
On Mon, Jul 29, 2024 at 12:09 PM Kevin Lewis @.***> wrote:
I was told "no one uses these and that they should be removed.
Check if Hydra_Feb19.yml was moved to the right place
You can view, comment on, or merge this pull request online at:
https://github.com/HEXRD/hexrd/pull/694 Commit Summary
- c3039fc https://github.com/HEXRD/hexrd/pull/694/commits/c3039fc26626ad748127316a38a7afd26fd8c618 Remove scripts folder
File Changes
(12 files https://github.com/HEXRD/hexrd/pull/694/files)
- R hexrd/resources/detector_templates/Hydra_Feb19.yml https://github.com/HEXRD/hexrd/pull/694/files#diff-84071bc8e0c6c8956e0bcd95660213c814f5d2ba100abe8ad03eb15cb4b5ff4a (0)
- D scripts/calibrate_from_powder.py https://github.com/HEXRD/hexrd/pull/694/files#diff-9d1338bdbff61cd14a46b752be25a1cb67a8f1691d422cceaabfba109fdfbec3 (591)
- D scripts/calibrate_from_powder.py.bak https://github.com/HEXRD/hexrd/pull/694/files#diff-bc7eadd6d4ac610533b36966489fc38386c7b5d811dcb2331a1b53a38bd8e3d7 (691)
- D scripts/calibrate_from_rotation_series.py https://github.com/HEXRD/hexrd/pull/694/files#diff-e011532deafaf403b1d44ddcf0c6f14742a5be0ed428bea1dc7dfc886b4ae57f (612)
- D scripts/calibration_mockup.py https://github.com/HEXRD/hexrd/pull/694/files#diff-7672cc3cb450d17b76cceed2e613bee9f2d9bced44f07b92e4e582506a2aaf2d (469)
- D scripts/convert_instrument_config.py https://github.com/HEXRD/hexrd/pull/694/files#diff-7659d9e3a8e5c2e021b6e43e8d09a8e9ded9d8f981d8ff86850cc5af7f754186 (161)
- D scripts/pinhole_2theta.py https://github.com/HEXRD/hexrd/pull/694/files#diff-3612180364ce6ceed0b88488ba45aeaf299534b00517490cf0e3cd6653d6cb0f (836)
- D scripts/plot_instrument_schematic.py https://github.com/HEXRD/hexrd/pull/694/files#diff-5e8c1954ab7197e8aaa066f4c059cf15fccf35105805a7abc592b540639feb31 (179)
- D scripts/powder_calibration.py https://github.com/HEXRD/hexrd/pull/694/files#diff-4d4eab32726e212d1e5540553983874c78eaf0636b9149d711110894e11fdaca (249)
- D scripts/preprocess_tomo_mask.py https://github.com/HEXRD/hexrd/pull/694/files#diff-85c050a83b85929d5cfaa584895307b8d2ef3c0f2ed66c4a499f8c37c377b301 (214)
- D scripts/process_nf.py https://github.com/HEXRD/hexrd/pull/694/files#diff-20ef94b5dcff8b91305f0864c3d8849dd5a2a050b22ab1743a2cd4ed6ea3cad0 (364)
- D scripts/tiffs_from_h5.py https://github.com/HEXRD/hexrd/pull/694/files#diff-dfafaf4f2d5e1e9bbc83050c65d0b9b93b67a181504be957f0ea480618814a82 (64)
Patch Links:
— Reply to this email directly, view it on GitHub https://github.com/HEXRD/hexrd/pull/694, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIWT6PFJX3U42JZ4GKOIC3ZOZSMLAVCNFSM6AAAAABLUS7LC6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGQZTKOBRG4YTMMA . You are receiving this because you are subscribed to this thread.Message ID: @.***>
I would hold off on that for now ask Kelly what she thinks. I don't think the scripts are maintained and I'm not sure any actually fully work, but these are the kind of things that people may use parts of. So we should save this for discussion the next HEXRD meeting.
Kelly specifically said to remove it. I'll add her as a reviewer so she can document the reasoning maybe
That's fine then!
On Mon, Jul 29, 2024 at 12:17 PM Kevin Lewis @.***> wrote:
I would hold off on that for now ask Kelly what she thinks. I don't think the scripts are maintained and I'm not sure any actually fully work, but these are the kind of things that people may use parts of. So we should save this for discussion the next HEXRD meeting.
Kelly specifically said to remove it. I'll add her as a reviewer so she can document the reasoning maybe
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>
Saransh approved as well.
I was told "no one uses these and that they should be removed."
Check if
Hydra_Feb19.yml
was moved to the right place