Open donald-e-boyce opened 1 month ago
Hello @donald-e-boyce! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
tests/test_transforms.py
:Line 63:11: E251 unexpected spaces around keyword / parameter equals Line 63:13: E251 unexpected spaces around keyword / parameter equals
This is a work in progress. It adds several groups of tests for
gvec_to_xy
could easily be extended to testxy_to_gvec
. The tests in include varying beam direction, theta and eta angles, translation vectors, detector orientation, sample and crystal orientations.It also includes tests that should return
nan
s, but these are inactivated due to Issue #704.