search

HEXRD / hexrd

A cross-platform, open-source library for the analysis of X-ray diffraction data.
Other
56 stars 25 forks source link

fix cartesian to reciprocal and direct space conversion #707

Closed saransh13 closed 4 weeks ago

saransh13 commented 4 weeks ago

702 revealed a bug in the cartesian --> reciprocal & direct space computation. Fixing the bug --all tests pass now.

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 33.06%. Comparing base (32009f3) to head (4d05337). Report is 2 commits behind head on master.

Files Patch % Lines
hexrd/material/unitcell.py 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #707 +/- ## ======================================= Coverage 33.06% 33.06% ======================================= Files 129 129 Lines 21281 21281 ======================================= Hits 7037 7037 Misses 14244 14244 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

saransh13 commented 4 weeks ago

This was already fixed in #702