search

HEXRD / hexrdgui

Qt6 PySide6 based GUI for the HEXRD library.
Other
29 stars 13 forks source link

Simple Imageseries import is not properly casting omega metadata #1254

Open joelvbernier opened 2 years ago

joelvbernier commented 2 years ago

If I do File → Import → Simple Image Series for an npz file that has discontinuous omega metadata (2 disconnected wedges), the eta-omega maps are not properly created (@psavery I will have to inspect the actually omega metadata). However, if I do File → Import → Image Stack and explicitly set the wedges, it seems fine. This would seem to indicate that the existing omega metadata on an npz file (IF it is there) is not being used, but rather the min and max from the file loading form (which only shows start/stop). This is not the desired behavior.

psavery commented 2 years ago

I believe it is currently using the omega start/stop from the file dialog because the user might modify the table to change the omega start/stop values.

Maybe we should add a checkbox that says "Use omegas from file?" which defaults to being checked and it disables the editing of the values in the table? That would make it clear that the user wants to use the values directly from the file as opposed to what is displayed in the table.

It might also be useful to just get the simple image series dialog to display and allow editing of the wedges as well, rather than just showing the range.

joelvbernier commented 2 years ago

We should probably enable A browser for the user to see omega metadata when it exists…. This requires a bit more thought. At least the stack importer works

Sent from my iPhone

On Jul 19, 2022, at 10:20, Patrick Avery @.***> wrote:

 I believe it is currently using the omega start/stop from the file dialog because the user might modify the table to change the omega start/stop values.

Maybe we should add a checkbox that says "Use omegas from file?" which defaults to being checked and it disables the editing of the values in the table? That would make it clear that the user wants to use the values directly from the file as opposed to what is displayed in the table.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were assigned.