search

HEXRD / hexrdgui

Qt6 PySide6 based GUI for the HEXRD library.
Other
29 stars 13 forks source link

Specify refinements for Laue overlays #561

Closed psavery closed 4 years ago

psavery commented 4 years ago

Add the ability to specify whether or not various Laue overlay options should be refined in the calibration.

joelvbernier commented 4 years ago

I'd like to see a table view of the parameters akin to the WPPF panel.

joelvbernier commented 4 years ago

Also... we need to expose the lattice parameter(s) for the case of powder diffraction overlays. @saransh13, probably best to go through PlaneData class as PlaneData.lparms is already symmetrically reduced. There is also logic in the material panel to cast the proper parameters names to the reduced list associated with the lattice type, a, b, c, α, β, γ.

joelvbernier commented 4 years ago

Looks like spacegroup knows how to parse the space group dependent number of reduced lattice parameters. @saransh13 can probably help with this.

psavery commented 4 years ago

@joelvbernier Do you mean we need refinements for the lattice parameters?

The lattice parameter values themselves are currently exposed on the bottom of the materials panel.

Screenshot from 2020-09-23 20-51-20

joelvbernier commented 4 years ago

@psavery -- we need access to the lattice parameter(s) only for the powder overlays. It might be faster to just update the lattice parameter for the PlaneData object used to draw the overlays (and passed to the optimization) rather than modifying the material itself. Not necessary for the Laue (Laue is insensitive to unit cell volume...)

psavery commented 4 years ago

Here's what the refinement editor looks like in the powder overlay editor in #568

image