HEnquist / camilladsp

A flexible cross-platform IIR and FIR engine for crossovers, room correction etc.
https://henquist.github.io/
GNU General Public License v3.0
551 stars 48 forks source link

unknown variant `Jack`, when build with --features jack-backend on windows #304

Closed alex-vyverman closed 11 months ago

alex-vyverman commented 11 months ago

Describe the bug I have an issue with v2 alpha5. I wanted to try out jack, but it doesn't seem to ben working. When I start using ` capture: channels: 8 device: default type: Jack

playback: channels: 8 device: default type: Jack`

I get 2023-10-30 22:17:23.802211 ERROR [src\socketserver.rs:1134] Error parsing yaml: devices.capture.type: unknown variantJack, expected one ofFile,Stdin,Wasapiat line 7 column 11, while I have build using cargo build --release --features jack-backend

It looks like it hasn't build the jack backend properly. There are a fair bit of warnings during compiling which I attached.

To Reproduce Steps to reproduce the behavior:

  1. build using cargo build --release --features jack-backend --features cpal-backend on win10 x64
  2. start jackd (optional)
  3. run camilladsp with jack backend

System info

Configuration win_jack8ch.yml.txt

Logs warnings.log 2023-10-30 22:17:23.802211 ERROR [src\socketserver.rs:1134] Error parsing yaml: devices.capture.type: unknown variant Jack, expected one of File, Stdin, Wasapi at line 7 column 11

HEnquist commented 11 months ago

Jack support is provided by cpal, and the problem here is that cpal doesn't support Jack on windows, only Linux. The warnings are basically all about unused code. It compiles the cpal backend, but since jack isn't supported and no other backend uses it, the cpal backend becomes unusable and inaccessible.

HEnquist commented 11 months ago

I see that the readme is quite misleading here. I'll update to make it clear that jack is only supported on Linux.

alex-vyverman commented 11 months ago

That clears it up. Thanks!