HEnquist / camillagui-backend

Backend server for camillagui
GNU General Public License v3.0
18 stars 4 forks source link

Added "coeff_dir" to gui config response #18

Closed JWahle closed 3 years ago

JWahle commented 3 years ago

This is for the GUI to compute the absolute paths of coeff files.

JWahle commented 3 years ago

I just removed the commit that uses relative paths for filter files, as this breaks filter and pipeline step plotting. @bitkeeper the last commit of this repo should be "Added "coeff_dir" to gui config response" - if you have an additional commit something about "relative filter paths", please revert to this version.

JWahle commented 3 years ago

@bitkeeper please note, that configs with relative paths to filter files currently don't work well in the GUI - the validation works, but plotting is broken for individual filters and also for pipeline steps. So, if you have a config with relative filter paths, simply reselect the same filter file in the GUI and it will insert the absolute path.

bitkeeper commented 3 years ago

@JWahle is the realtive path against the active config not working something temporary ?

Before it worked well with relative paths against the config.yml for the plotting. This will make it less portable for users (they have to know where the the files will be on the specific target). If it keeps this way I need to patch in moOde all existing or new user uploaded config files to use abs path.