HEnquist / camillagui-backend

Backend server for camillagui
GNU General Public License v3.0
18 stars 4 forks source link

Use relative paths for filter coeff files #19

Closed JWahle closed 3 years ago

JWahle commented 3 years ago

@JWahle is the realtive path against the active config not working something temporary ?

Before it worked well with relative paths against the config.yml for the plotting. This will make it less portable for users (they have to know where the the files will be on the specific target). If it keeps this way I need to patch in moOde all existing or new user uploaded config files to use abs path.

Originally posted by @bitkeeper in https://github.com/HEnquist/camillagui-backend/issues/18#issuecomment-784221869

JWahle commented 3 years ago

@bitkeeper I thought it never worked - I'll have a look at what breaks it now.

JWahle commented 3 years ago

@bitkeeper are you sure, plotting for convolution filters ever worked with relative file paths? I reverted back to just before my first commit and it doesn't work for me (backend back to 03abebea2dc490961167d06ed2e96f96e73bbda3 and frontend back to 3d56109e0bcaca0302f71ea635dc7e0f9b503048).

bitkeeper commented 3 years ago

@JWahle you are completely right about that, my mistake, I prob mixed it up with the plot of PEQ filters. And before that is was alway required to 'load from cdsp' and in that way the files names returned by cdsp where are full path names.

JWahle commented 3 years ago

I also think, GUI support for relative filter paths would be nice to have, but I'm not sure, if this is worth the hassle. I'll try an implementation, but no promises here :)

bitkeeper commented 3 years ago

@JWahle so I can remove the rel to abs patch of config files in moOde ?

JWahle commented 3 years ago

@bitkeeper yes, I think so. On a side note: Henrik has not tested this, but an implementation to automatically set the parameters for convolution files (https://github.com/HEnquist/camillagui/issues/40) is also in the develop branch. I'd appreciate, if you could try it out.