search

HEnquist / camillagui

GNU General Public License v3.0
9 stars 1 forks source link

Missing 'ramp_time' option in Volume filter doesn't trigger a parsing error #112

Open t-gh-ctrl opened 3 months ago

t-gh-ctrl commented 3 months ago

Versions: CamillaDSP 2.0.3, pyCamillaDSP 2.0.2, Backend 2.1.1

One of my (hand written) config files works perfectly fine with camilladsp and doesn't trigger any parsing issue when loaded into camillagui (either with Files/Load into Gui, or "Fetch from DSP"); but clicking on the "Filters" tab results in a blank page shown. The other tabs (pipeline, mixer, ...) work.

After a bit of bisecting, the culprit seems to be how I defined a Volume effect:

  volumeX:
    type: Volume
    parameters:
      fader: Aux1

Notice the lack of ramp_time parameter - which shouldn't be required (as per the doc - there's an (*) after this parameter and it defaults to 200).

If I'm then saving this config from camillagui, that's what gets written:

volumeX:
    description: null
    parameters:
      fader: Aux1
      ramp_time: null
    type: Volume

The resulting file can be loaded back into camillagui without any parsing error, and triggers the same issue like the config with the missing ramp_time parameter. Interestingly, loading that file into camilladsp doesn't trigger any error (so I guess that either null is ignored, or is taken as 0) - but I didn't want to file an almost identical issue in camilladsp.

Changing ramp_time to a numerical value fixes the issue - ie. the filter tabs shows all the filters properly.

[edit - thank you for your great work!]

HEnquist commented 3 months ago

Thanks for reporting! The problem is that the ramp_time parameter isn't optional in the gui, but it is in both camilladsp and the config validator (in the backend). I have fixed it for the next version, see https://github.com/HEnquist/camillagui/commit/d7080b4110691200c9ddb3232150d8ef44071478 Considering that 3.0 is nearly ready, and that the problem can be avoided by giving the ramp_time some value, I don't think it's worth spending time on a new release for v2.

t-gh-ctrl commented 3 months ago

Wow, you were fast ! :)

Considering that 3.0 is nearly ready, and that the problem can be avoided by giving the ramp_time some value, I don't think it's worth spending time on a new release for v2.

Sure! (that's a very minimal issue anyway).

I'm closing this issue then.

May I ask you a side question: what is the best place/forum to ask questions about camilladsp? ASR? I'm getting some cryptic (to me) warning messages (re- alsa buffer manager) and have no idea if I should file an issue or if the problem is in my configuration...

HEnquist commented 3 months ago

This thread is probably the best place: https://www.diyaudio.com/community/threads/camilladsp-cross-platform-iir-and-fir-engine-for-crossovers-room-correction-etc.349818/

HEnquist commented 3 months ago

Let's keep this open until the next version is released, in case someone else has the same problem.