search

HEnquist / camillagui

GNU General Public License v3.0
9 stars 1 forks source link

Pipeline import from REW failure #115

Closed mike811 closed 1 month ago

mike811 commented 1 month ago

Hello Henrik,

could you share some insight about the format questions regarding type fields etc.? Please take a look here: https://www.avnirvana.com/threads/camilladsp-iir-format-output.11060/page-2 What I get importing this is (from REW beta 39): C_TT_RTA_3_Mic_FR.yml.zip First it looks ok in the web gui: image But then there is this red error triangle with (excl. mark) at the pipeline tab and this tab is empty. Browser reload brings pipeline view back but filters and its group were not added. image Just importing filters without its pipeline group works btw.

mike811 commented 1 month ago

This works: image So it seems "- names" was wrong.

HEnquist commented 1 month ago

pipeline is supposed to be a list of objects (with each object representing a pipeline step), but in the previous REW export pipeline is just a single object instead of a list. It also lacks the channel property. The import function of the gui has a little bit of extra logic to handle these files. If the REW output has changed, then this may need an update. The easiest would be if REW exported a completely valid pipeline section so that nothing extra needs to be done.

mike811 commented 1 month ago

Hello Henrik,

John implemented a complete pipeline section with channel property. It is working fine here. Maybe you could change the pipeline 0 stuff from the import window and display the channel number from the section? Pipeline section looks like this now: image

Regards Michael

HEnquist commented 1 month ago

Great, this simplifies things! The pipeline 0 thing has to stay, the same logic handles import of all camilladsp config files where there may be many steps, and more than one step may filter any given channel. The channel number should be shown in the tooltip.