"Rate adjust" section is now hidden for stdin/file/pulse audio playback devices

HEnquist / camillagui

GNU General Public License v3.0

9 stars 1 forks source link

"Rate adjust" section is now hidden for stdin/file/pulse audio playback devices #16

Closed JWahle closed 3 years ago

JWahle commented 3 years ago

According to the CamillaDSP documentation, rate adjust is not available for pulse audio capture devices, so it is now also hidden from the GUI when a pulse capture device is selected.

HEnquist commented 3 years ago

It's actually supported for all capture devices, but only when using an Alsa, Wasapi or CoreAudio playback device! I should have seen this already in the previous PR, sorry.. As long as the asynchronous resampler is enabled, rate adjust can be used with all capture devices. And if the Alsa capture device is capturing from a Loopback, then it can also do rate adjust without resampling.

HEnquist commented 3 years ago

When using any of these playback devices:

Pulse
File
Stdin

Then these options have no effect and can be hidden:

enable_rate_adjust
adjust period
target_level (and this one should probably move to the Rate adjust group)

JWahle commented 3 years ago

Alright, I fixed it to hide rate adjust based on the OUTPUT device, not the INPUT device and also moved target_level to rate adjust option group.

HEnquist commented 3 years ago

Just tested, works great!