search

HEnquist / camillagui

GNU General Public License v3.0
9 stars 1 forks source link

Plotting for filters with variables in filename #43

Closed JWahle closed 2 years ago

JWahle commented 3 years ago

Convolution filters with variables in filename ($samplerate$, $channels$) cannot be plotted individually and also break plotting of any filter pipeline step that contains them.

Optimally, I would like, that for filters with variables in filename :

HEnquist commented 3 years ago

The plotter will need the absolute path to the filter coeff files, with the variables substituted. Probably the backend is the easiest place to handle that.

JWahle commented 3 years ago

With the "select field with all variants in the filter plot view", I will probably need to change both. But you are right - the majority of changes will go in the backend. I'll probably try an implementation next weekend.

HEnquist commented 3 years ago

I fixed it now so that it works to plot filters with tokens. It's using the samplerate and number of channels from the devices section, I did not implement any option for quickly plotting other combinations.

JWahle commented 3 years ago

Works for me. I'll leave this ticket open, until I implemented the rest.

JWahle commented 2 years ago

Hi @HEnquist, I just pushed an implementation of this to the develop branches of front- and back-end.

Currently, there is no validation - I doubt, that it would be as easy as I imagined it, when I created https://github.com/HEnquist/pycamilladsp-plot/issues/10. So, I don't plan to implement this for now.

Feel free to reopen the ticket, if you find some bugs regarding this feature.

HEnquist commented 2 years ago

Alright! I'll try it as soon as I can. I'll merge this to master when I also merge the changes for camilladsp 1.0.0, hopefully quite soon.

JWahle commented 2 years ago

@HEnquist FYI I added a build step that runs python unit tests in https://github.com/HEnquist/camillagui-backend/commit/e9488b7973da6cb6d7b15dade7b5240edc49255d