HEnquist / camillagui

GNU General Public License v3.0
9 stars 1 forks source link

Gui doesn't show correct version of camilladsp when offline #47

Closed bitkeeper closed 3 years ago

bitkeeper commented 3 years ago

Minor issue; when opening the editor while camilladsp hasn't been online mode no camilladsp version is shown. Just a tripple x version:

image

Once you have been online the correct version is shown, even if you go back to offline mode.

HEnquist commented 3 years ago

The CamillaDSP version is read from the camilladsp process over the websocket. When it hasn't been online yet, the gui can't know. The only way around that would be to store the version number separately somewhere. That would make it always show something, but then it isn't guaranteed to be correct..

bitkeeper commented 3 years ago

I see that the offline (_with setting backup_camillapath) isn't used anymore, so that can also not be a source of the version. Would it be an option to just call camilladsp --version (from the setting backup_camilla_path setting) from the backend to capture the version? If not just feel free to close the issue, because it a very minor one :-)

Supporting case: It would ease support, because when you have a problem and camilladsp will not start, you will have no way to the see the current camilladsp version, without forcing the user to the commandline.

HEnquist commented 3 years ago

Yes the backup camilladsp instance was removed since we don't need it for config validation any more. That would then need to be added back. I see the point for support, but my feeling is that this could generate more trouble than it prevents. The user then must configure the path to the camiladsp executable, and must keep it updated if things change. Forgetting to update (or just picking the wrong path in the first place) could mean the version shown is from the wrong executable.

bitkeeper commented 3 years ago

Clear lets close this one.