search

HEnquist / camillagui

GNU General Public License v3.0
9 stars 1 forks source link

replace the fixed function Bass&Treble eq sliders with configurable controls #93

Closed JWahle closed 7 months ago

JWahle commented 7 months ago

@HEnquist how do you envision this?

HEnquist commented 7 months ago

Now there are two sliders for two filters with fixed names, both controlling the gain parameter. The first thing that could be done is to allow the user to define their own sliders by giving the filter name, which parameter to control, and what range the slider should cover. That could be done in the gui config to start with.

Later improvements could be to allow defining them in the gui (supported by the backend via endpoints for storing and reading them)

JWahle commented 7 months ago

Sounds easy to do, I'll try something

mike811 commented 7 months ago

Hello,

sounds great. I could use this to mix e.g. Front (left) with Surround (left) to generate Front Wide (left) and having some sort of pan control.

JWahle commented 7 months ago

I like the idea, but after thinking about this, it seems the best place for this UI Control configuration would be inside each CamillaDSP config - not all configs offer the same controls. @HEnquist what do you think?

HEnquist commented 7 months ago

You mean that each config would somehow indicate what parameters should get a slider (and the range for it)? That could also be a way, but then it becomes a much larger project to build. Sometimes it's likely better to keep this in the config. But then this needs to be added to every config. So sometimes, if most configs will have the same sliders anyway, it would be better to keep this separately.

I think that defining them in a single separate config is a pretty small effort, so in any case this is a good start. Then later on it could be expanded in all kinds of ways.

JWahle commented 7 months ago

I implemented the simple version in the develop branch of backend and frontend. It works exactly like before, but the layout changed a little bit, because I wanted to keep the configuration as simple as possible: image

Now users can configure their own sections with individual sliders. Currently only number values are supported.

You mean that each config would somehow indicate what parameters should get a slider (and the range for it)?

Yes, my idea was basically to move the additional config snipped, that is now in the gui-config.yaml into the individual configs. With the config import functionality this should provide good usability.

Shall we leave it like this for now?

HEnquist commented 7 months ago

Looks great, I think this is perfect for now.