HEnquist / camillagui

GNU General Public License v3.0
9 stars 1 forks source link

Filters page blank if channel not defined for Wav convolution file #97

Closed charleski closed 5 months ago

charleski commented 7 months ago

CamillaDSP 2.0.1 pyCamillaDSP 2.0.2 Camillagui Backend 2.0.1

If using an FIR filter with a mono Wav convolution file, the docs state that the channel parameter is optional (there's only one channel anyway). But a config file with such a filter will lead to camillagui rendering a totally blank page on switching to the 'Filters' tab. The only way to escape is to refresh the page (which loads the default config).

Example: The following filter spec causes a blank Filters tab:

  IR_HpCF:
    parameters:
      filename: /home/tc/camilladsp/coeffs/HpCF_HiFiMAN_Ed_XS_Ave1_$samplerate$.wav
      type: Wav
    type: Conv

But if I change it to

  IR_HpCF:
    parameters:
      channel: 0
      filename: /home/tc/camilladsp/coeffs/HpCF_HiFiMAN_Ed_XS_Ave1_$samplerate$.wav
      type: Wav
    type: Conv

the Filters tab renders properly. The wav file used is mono and the config loads and plays through camilladsp just fine without the channel parameter.

I'm using the latest version of camillagui, but only recently decided to try this filter, so can't say if the bug is present on previous versions.

HEnquist commented 7 months ago

Thanks! There were lots of changes to the handling of defaults and optional values for 2.0. I thought all properties were updated but looks like channel was forgotten.

HEnquist commented 7 months ago

fixed in af76932115bb611ce8e456a313dff9b06eb423cf