search

HExSA-Lab / nautilus

Nautilus Aerokernel
Other
44 stars 60 forks source link

fix bugs in construct_tables_4K and 2M #18

Closed zjp0317 closed 5 years ago

zjp0317 commented 5 years ago

-- Bug:

  1. A typo in _fill_pd()
  2. Currently, construct_tables_4K (and 2M) directly fills each PDPT and/or PD with the total amount of PDPT/PD entries. -- Fix: Calculate the actual number of entries to be filled for each PDPT/PD.

-- It does not introduce breaking change.

zjp0317 commented 5 years ago

Thanks for the PR. Please see the comments in-line. Once those are in, I'll add another review request. Also, has this patch been tested on any physical hardware?

Not yet, currently I only ran it on my VMware.

khale commented 5 years ago

OK, after reviewing this looks good to me. @PeterDinda I've assigned you to review as well since I believe you added these a while back. FWIW this may have been the cause of our troubles in #1 and maybe #17. If it looks good I'll go ahead and merge in.

Oh, and to be clear this is coming from Jingpeng, one of Jack's students.

PeterDinda commented 5 years ago

You mentioned I wrote some of this. I don't recall, and it's committed with your name. Is this stuff borrowed from HVM, perhaps? Or Palacios?

khale commented 5 years ago

Hmm I guess I'm misremembering. I don't think it came from either of those. That was a pretty feverish month of additions so I probably wrote it and lost track.