khale
commented
5 years ago This pull request introduces 2 alerts and fixes 2 when merging 01a4950fe27be0f30d27031fcbd400b9622e08c5 into d52494940a96704b0cb3ae6964a12db36361d3e0 - view on LGTM.com
new alerts:
- 1 for Wrong type of arguments to formatting function
- 1 for Function declared in block
fixed alerts:
- 2 for Local variable hides global variable
Warning - Automated code review for HExSA-Lab/nautilus will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog.
Comment posted by LGTM.com
Major new things here are the addition of futures, and a refactor of the openmp code to make room for more than one openmp implementation.
Bug fixes: timer race, incorrect handling of stack checks in scheduler (only visible with fibers, which is n upcoming addition), use of low-level memcpy/memset in vga in order to be compatible with KVM (this is a more general issue - compiler may use SSE to talk to MMIO, which breaks in KVM and similar because they don't emulate SSE for MMIO).
Also has minor restructuring of task code.