search

HFIProgramming / NoticeBoardwith5.3

5.3 with profile
3 stars 4 forks source link

Hard-Code error message in errors view #23

Open NeverBehave opened 7 years ago

NeverBehave commented 7 years ago

@wsjnohyeah Please don't hard code the error message in the error pages. You can use {{ trans('messages.welcome') }} or @lang('messages.welcome') function if you need to insert a fixed message in the view.

You can check out the documentation here if you need some example, or you can check out the history version of 404.blade.php.

I have written some of the error messages so please follow the instruction XD, we need a Chinese version at the I18n Day.

NEXT TIME PLEASE READ AND FOLLOW THE EXISTING CODES: IT IS ALSO AN IMPORTANT SKILL TO READ OTHERS CODES RATHER THAN CLEAR THEM OUT AND APPLY YOUR IDEA DIRECTLY THESE CODES ARE WRITTEN FOR REASONS On the other hand, custom error looks good.

wsjnohyeah commented 7 years ago

Error messages are passed in when abort() is called. For default messages, maybe Lang is a better idea. But indeed there are lot of grammar mistakes

yhylord commented 7 years ago

CAPITALIZED LETTERS ARE HARD TO READ AND SHOW YOU'RE RUDE. Just use normal English style and give the reason. I don't see emotions can help you code.

2017-03-06 9:20 GMT+08:00 NeverBehave notifications@github.com<mailto:notifications@github.com>:

@wsjnohyeahhttps://github.com/wsjnohyeah Please don't hard-code the error message in the error pages. You can use {{ trans('messages.welcome') }} or @lang('messages.welcome') function if you need to insert a fixed message in the view.

You can check out the (documentation)[http://d.laravel-china.org/docs/5.3/localization] here if you need some example, or you can check out the history version of 404.blade.php.

I have written some of the error messages so please follow the instruction XD, we need a Chinese version at the I18n Day. NEXT TIME PLEASE FOLLOW THE STYLE: IT IS ALSO AN IMPORTANT SKILL TO READ OTHERS‘ CODE RATHER THAN CLEAR THEM OUT AND APPLY YOUR IDEA DIRECTLY. THESE CODE ARE WRITTEN FOR REASONS. On the other hand, custom error looks good.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/HFIProgramming/NoticeBoardwith5.3/issues/23, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFA_P9v_hrhEYB9e1wSofZaqoEvWrq7Oks5ri19TgaJpZM4MToac.

NeverBehave commented 7 years ago

@wsjnohyeah Okey, XD I really appreciate if you can help fix these parts.