HFenter / MarginBot

Bitfinex Margin Lending Managment Bot
Other
114 stars 49 forks source link

" PHP Notice: Undefined index: price" error causes an unaccesable webpage #19

Open SnellePeer opened 7 years ago

SnellePeer commented 7 years ago

Note/disclaimer: I have little experience with php programming

I have a domain hosted on which has one subdomain. On this subdomain i installed MarginBot. When i got to the correct address i noticed the webpage just kept on loading. I checked the server logs and found out they where being flooded with the message:

[Fri Oct 13 20:26:06.405827 2017] [proxy_fcgi:error] [pid XXXXX:tid XXXXXXXXXXXXXXXXXX] [client xx:xx:xx:xx:XXXXXX] AH01071: Got error 'e/XXXX/domains/XXXXX.XX/public_html/marginbot/inc/ExchangeAPIs/bitfinex.php on line 78\nPHP message: PHP Notice: Undefined index: price in /home/XXXXX/domains/XXXXXX.XX/public_html/marginbot/inc/ExchangeAPIs/bitfinex.php on line 78\nPHP

I looked up the file bitfinex.php and went to line 78. Here below is the function that line 78 belongs to:

`    /* Data posting query, for detailed API calls */
     function bitfinex_query($method, array $req = array()) {
        // API settings

        $req['request'] = '/v1/'.$method;
        $this->nonceInc += 1;
        $req['nonce'] = (string)$this->nonceInc;
        if($req['price']){$req['price'] = (string)$req['price'];}

        // generate the POST data string
        $reqData = base64_encode(json_encode($req, true));
        $post_data = http_build_query($req, '', '&');
        //print_r($post_data);
        $sign = hash_hmac('sha384', $reqData, $this->apiSec);

        // generate the extra headers
        $headers = array(
            'X-BFX-APIKEY: '.$this->apiKey,
            'X-BFX-PAYLOAD: '.$reqData,
            'X-BFX-SIGNATURE: '.$sign
        );`

Further information: -When installed MarginBot i then configured my bitfenix account using the MarginBot webpage gui. (I could still access and use the webpage -I made a second user account

After the things mentioned above the webpage became unaccesable. I'm guessing i'm making an obvious mistake here which i am sure one of you can assist me with.

Further more an other error popped up in the server logs:

[Fri Oct 13 20:26:23 2017] [proxy_fcgi:error] [pid XXXXX:tid XXXXXXXXXXXXXX] (70007)The timeout specified has expired: [client XX.XXX.XX.XXX:XXXXX] AH01075: Error dispatching request to : (polling)

However i'm betting this is merely the result of endless loading due to timeout

HFenter commented 7 years ago

The latest minor update 1.08a will prevent the notice log spam. I'm guessing this isn't the main problem you are having here, but at least your logs won't fill up if you upgrade.