search

HGInsights / avalanche

Avalanche is an Elixir Snowflake Connector built on top of the Snowflake SQL API v2.
Apache License 2.0
17 stars 4 forks source link

fix typespecs, replace mentat with cachex, fix flaky test, improve docs #38

Closed andyleclair closed 1 year ago

andyleclair commented 1 year ago

Hi! First, thank you so much for this library! ODBC is a real pain, and it doesn't work with non-ASCII characters in a query.

I wanted to submit this to you because I know Keathley can be a bit slow, and since people have been waiting months for a proper Mentat release that matches main, I don't want to hold my breath about it. I've used Cachex, and it's a perfectly usable replacement. I've set the cache options to match Mentat, so it won't change any behavior of the janitor timing.

I also fixed a few typespecs (token was listed as only binary when it could also be keyword), updated the docs for the token auth parameter, and I fixed a flaky test caused by using Mimic across process boundaries.

Please let me know if you're interested in accepting any of these changes! Thanks again!

forest commented 1 year ago

@andyleclair, thanks for the contributions. I have been thinking we need to replace Mentat.

andyleclair commented 1 year ago

I saw that linting step failed, it may be a few days until I can resolve that, my wife and I are about to go to the hospital to have a baby 😅

forest commented 1 year ago

my wife and I are about to go to the hospital to have a baby 😅

We got you! Your wife and baby are a priority!

pdgonzalez872 commented 1 year ago

@andyleclair thanks for doing this!

Congrats on the baby! ❤️

hgdeploy commented 1 year ago

:tada: This PR is included in version 0.11.6 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

andyleclair commented 1 year ago

Thank you both!