HGustavs / LenaSYS

Code Viewer and Course Organization System used in some courses at University of Skövde
57 stars 31 forks source link

Research if microservices cover the entire functionality of profileservice.php #15359

Closed f22linhe closed 6 months ago

f22linhe commented 6 months ago

Review the microservices in the profileService folder. Do these microservices cover the entire functionality of the original service file, profileservice.php? If you find any functionalities that are not covered, do we need to create a new microservice for this functionality?

https://github.com/HGustavs/LenaSYS/blob/g2-2024-v5/DuggaSys/profileservice.php

c22emigr commented 6 months ago

In the folder profileService we created 2 microservices. One that handles setting/updating security question and one ms for changing a users password. Everything from the monolith file is used by the 2 microservices and are ready to be migrated and replace the monolith file (profileservice.php).

a22eriwi commented 6 months ago

Me and c22emigr created 2 different ms: "updateSecurityQuestion_ms.php" and "updateUserPassword_ms.php" which are both located in the profileService folder. There doesn't seem to be anything that is missing from the profileservice.php file that needs to be implemented somewhere else. In my opinion this issue can be closed now.