HGustavs / LenaSYS

Code Viewer and Course Organization System used in some courses at University of Skövde
57 stars 31 forks source link

Consistent dark mode #7761

Open HGustavs opened 4 years ago

HGustavs commented 4 years ago

I have added dark mode syntax highlighting to the php syntax highlighter that I made for the apache directory listing app that I made

https://github.com/HGustavs/FileLister

I want similar handling throughout lenasys.

Together with simplification of the current css

                @media (prefers-color-scheme: dark) {
                        .htmltag{
                                color:#de935f;
                        }

                        .htmltagend{
                                color:#de935f;
                        }

                        .divider{
                                color:#c5c8c6;
                        }

                        .string{
                                color:#8f9d6a;
                        }

                        .variable{
                                color:#f9ee98;
                        }

                        .comment{
                                color:#bbb;
                        }

                        .name {
                                    color:#607392;
                        }
                        .func{
                                color:#cf8843;
                        }               

                        .numeric {
                                    color: #ffcc00;
                        }

                        .hi{
                                background:#480;                            
                        }

                }

                @media (prefers-color-scheme: light) {
                        .htmltag{
                                color:darkred;
                        }

                        .htmltagend{
                                color:darkred;
                        }

                        .func{
                                color:darkgreen;
                        }               

                        .divider{
                                color:cadetblue;
                        }

                        .string{
                                color:orange;
                        }

                        .numeric{
                                color:orange;
                        }                   

                        .variable{
                                color:darkmagenta;
                        }

                        .comment{
                                color:#bbb;
                        }

                        .hi{
                                background:#dfd;                            
                        }

                }
HGustavs commented 4 years ago

Not only for the syntax highligthing but in ALL of the various views.

a16silph commented 4 years ago

Right now I’m stuck with the dark mode styling in codeviewver.php. Some styling is created in JavaScript and I cannot seem to find the source code for the styling of that markdown syntax.

image

HGustavs commented 4 years ago

I think markdown has its own css file?

HGustavs commented 4 years ago

Like markdown .css ??

a16silph commented 4 years ago

Since LenaSys is quite vast it would be more productive to split this task into several smaller tasks focusing on adding dark mode to the different parts of the website. This would also help since it would otherwise be difficult not to interfere with other groups and their work while adding the functionality.

a18filkr commented 4 years ago

We are done with group1 priorities but will keep this open for other groups to fix dark mode.

a20sarle commented 2 years ago

To avaoid collisions during merge group 2 should not work with dark mode regarding the iframe on diagram page since customer had specific wishes for the design of that page which group 3 is currently working on.

b20fanfa commented 2 years ago

Dark mode colors for the code viewer can be found here #11449. Dark mode colors for LenaSYS in general can be found here https://github.com/HGustavs/LenaSYS/wiki/CodeViewer#lena-sys-start---dark-mode.