Change type casting CMTime to NSValue using NSValue constructor

HHK1 / PryntTrimmerView

A set of tools to trim, crop and select frames inside a video

MIT License

835 stars 199 forks source link

Change type casting CMTime to NSValue using NSValue constructor #66

Closed heoblitz closed 4 years ago

heoblitz commented 4 years ago

What is this PR for?

Change type cast CMTime to NSValue using NSValue constructor

Why are we doing this?

XCode 12.0 beta 6, iOS 14, Swift 5 Fix Compile error "Cannot convert value of type 'CMTime' to type 'NSValue in coercion"

ScreenShots

CreatorMetaSky commented 4 years ago

Perfect.

HHK1 commented 4 years ago

Thanks @heoblitz, appreciate it 👍 Leaving this on master for now, I'll do the release when Xcode 12 is out of beta

alinmuntean commented 4 years ago

Hi @HHK1 , Is it possible to have a sooner release of this fix? We're using the following framework: https://github.com/Yummypets/YPImagePicker which uses this framework and our project won't compile in Xcode 12 beta 6 at the moment. We'd like to have a release of our app sooner than the actual release date of iOS 14 / final Xcode 12. Kind regards, Alin

HHK1 commented 4 years ago

Ok @alinmuntean, makes sense. I'll publish the fix soon then

alinmuntean commented 3 years ago

Ok @alinmuntean, makes sense. I'll publish the fix soon then

Hi @HHK1 , can you please tell us what's the status with this one? Thanks!

rolandtolnay commented 3 years ago

With Xcode 12 officially released now, I am facing the same issue as above. Looking forward to the published fix.