search

HHK1 / PryntTrimmerView

A set of tools to trim, crop and select frames inside a video
MIT License
835 stars 199 forks source link

Question about right handle when it's not moved #77

Closed jeongbalmount closed 3 years ago

jeongbalmount commented 3 years ago

When the right handle is still and only the left handle is moved, the video is not played again but stops. Is there any way to fix this?

HHK1 commented 3 years ago

Could you expand a bit please ? When you move a handle, the asset shows the image associated with the current position of the handle (to help you get a precise position for trimming), and playback should resume once you lift your finger up.

jeongbalmount commented 3 years ago

I know what you're talking about. What I want to say is that video does not repeat when the right handle is located at the end of the trimmer. Mar-17-2021 19-07-56

Not all videos are like this, but only a few videos seem to have this problem. And if right handle moves at least once and go back to the end of the Trimmer, the video repeats itself.

HHK1 commented 3 years ago

Got it, thanks for the video, makes it clearer. I currently don't have time to investigate this, but feel free to open a PR and I'll review it 🙏

jeongbalmount commented 3 years ago

Thanks! 👍

xaphod commented 3 years ago

PR that fixes this: https://github.com/HHK1/PryntTrimmerView/pull/81/files

jeongbalmount commented 3 years ago

Sorry for the late reply! I changed the code and tested it, but it stops the same 😢 . And also same result in PryntTrimmerViewExample. I added observer to the part where I put AVasset in the AVplayer and added itemDidFinishPlaying to check if the player was stopped, did I applied wrong?

xaphod commented 3 years ago

Hi @jeongbalmount if you are talking about the fix in my PR, since it has been merged you can just pull the newest code from this repo. You should not need to manually change code

jeongbalmount commented 3 years ago

I added swift Package(https://github.com/xaphod/PryntTrimmerView.git) but it didn't work. Is this not the right way to do it?

xaphod commented 3 years ago

I am not familiar with swift packages so i dont know

On Tue, May 11, 2021 at 8:17 AM jeongbalmount @.***> wrote:

I added swift Package(https://github.com/xaphod/PryntTrimmerView.git) but it didn't work. Is this not the right way to do it?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/HHK1/PryntTrimmerView/issues/77#issuecomment-838374626, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4Z6LXCAH5Q75RTLXY4BATTNEN5BANCNFSM4ZKH22NQ .

-- Tim Carr Founder, Solodigitalis M: 289-237-1935 W: solodigitalis.com A: 270 Sherman Ave N, Hamilton, ON L8L 6N4

jeongbalmount commented 3 years ago

I was really stupid! I declared a new Notification name 😅 (AVPlayerItemDidPlayToEndTime) Thanks @xaphod!!