search

HHRy / showoff2pdf

Converts ShowOff presentations to PDF documents ready to print by leveraging a custom built Markdown parser and the wonderful Prawn PDF Library.
http://ryanstenhouse.eu
MIT License
3 stars 0 forks source link

Image handling is awful #1

Open HHRy opened 13 years ago

HHRy commented 13 years ago

Current behavior for handling images pulls in all image files throughout the showoff presentation and stores their paths in an array, then when an image element is encountered, this array is searched for the corresponding image to be included.

Obviously this has some quite serious performance and efficiency implications, a better way to deal with this is a must.

HHRy commented 13 years ago

While I've not addressed the performance problems of the inefficient way I'm dealing with images, I've made showoff2pdf a lot more clever when it comes to ensuring that images fit on the page.