I'm not sure how obectiveCreatedHere would diverge across activity report objectives but we do not need to use it as a key for deduplicating objectives; if one ARO within an objective is set to true, they should all be true. This is only used as one factor as to whether the objective's text is editable so the risk of changing this is extremely low.
How to test
Download the latest prod backup, impersonate the user and view the report from the support case, and confirm that none of the open objectives are duplicated. There are objectives duplicated across the goals but that looks to be intentional.
Description of change
I'm not sure how obectiveCreatedHere would diverge across activity report objectives but we do not need to use it as a key for deduplicating objectives; if one ARO within an objective is set to true, they should all be true. This is only used as one factor as to whether the objective's text is editable so the risk of changing this is extremely low.
How to test
Download the latest prod backup, impersonate the user and view the report from the support case, and confirm that none of the open objectives are duplicated. There are objectives duplicated across the goals but that looks to be intentional.
Issue(s)
Checklists
Every PR
Before merge to main
Production Deploy
After merge/deploy