[TTAHUB-3611] Fix goal source validation

thewatermethod commented 2 weeks ago

Description of change

Prevent submitting a goal via the RTR with no goal source. Mark section invalid on AR if goal is missing source

How to test

Confirm that you can't create a goal with no source on RTR or submit an AR with a goal that has no source Multi-grant/recipient reports do not show the source field in the UI. Confirm you can submit a multi-grant/recipient report

Issue(s)

https://jira.acf.gov/browse/TTAHUB-3611

Checklists

Every PR

[ ] Meets issue criteria
[ ] JIRA ticket status updated
[ ] Code is meaningfully tested
[ ] Meets accessibility standards (WCAG 2.1 Levels A, AA)
[ ] API Documentation updated
[ ] Boundary diagram updated
[ ] Logical Data Model updated
[ ] Architectural Decision Records written for major infrastructure decisions
[ ] UI review complete

Before merge to main

[ ] OHS demo complete
[ ] Ready to create production PR

Production Deploy

[ ] Staging smoke test completed

After merge/deploy

[ ] Update JIRA ticket status

thewatermethod commented 2 weeks ago

Overall looks good. However one thing I noticed but not sure if its part of this ticket.

Create an AR

Add two recipients

Create a goal without setting a source (as its not required for multi recip reports), then save the goal

fill out the rest of the AR and save

Now go back to the summary remove one of the recipients

You are still able to submit the report with the goal now missing a source (also approve it)

If this is outside the scope of this ticket let me know and I can approve.

@AdamAdHocTeam You shouldn't be able to submit the report... were you able to?

AdamAdHocTeam commented 2 weeks ago

Overall looks good. However one thing I noticed but not sure if its part of this ticket.

Create an AR

Add two recipients

Create a goal without setting a source (as its not required for multi recip reports), then save the goal

fill out the rest of the AR and save

Now go back to the summary remove one of the recipients

You are still able to submit the report with the goal now missing a source (also approve it)

If this is outside the scope of this ticket let me know and I can approve.

@AdamAdHocTeam You shouldn't be able to submit the report... were you able to?

@thewatermethod yes and approve.

HHS / Head-Start-TTADP