Improve Edit/Resolve Errors on Send to Approval

HHS / OPRE-OPS

ACF's OPRE OPS product. Code name Unicorn.

Other

12 stars 3 forks source link

Improve Edit/Resolve Errors on Send to Approval #2098

Open kimschulke opened 6 months ago

kimschulke commented 6 months ago

Goals

Improve the user workflow to edit/resolve errors during send to approval
Currently, in dev, when a user clicks Send to Approval and sees errors to resolve, they click Edit and are taken to the Create Agreement workflow. However, this does not match Figma or the intended user path.
When a user clicks Edit to resolve errors during Send to Approval, they should instead be taken to a single page where they can address the errors without having to go through the Create Agreement wizard.

Tasks

[ ] Update dev to match user workflow designed in Figma

Additional Context

https://github.com/HHS/OPRE-OPS/issues/677

Resources

fpigeonjr commented 3 months ago

the single page edit has not been built

fpigeonjr commented 2 weeks ago

Resolve page renders the agreement form and SC and Budget Lines forms
Validation is working
TODO: save all button logix

kimschulke commented 2 weeks ago

@npage123 @andressacurvelo @kimschulke need to review edit workflows in general to see if we can find a solution that works for all edit experiences. Right now we have a few experiences:

Edit Agreement details tab and only edit agreement details Edit SCs & BLs tab and only edit SCs & BLs Edit during status change and edit everything on one page OR Edit during status change and edit in 3 step wizard

There are some dev issues/higher level of effort in regards to editing the whole agreement on one page

fpigeonjr commented 1 week ago

@kimschulke should we move this back to needs refinement?

npage123 commented 5 days ago

I think that's a good idea @fpigeonjr. Based on how you explained that this is more difficult because of how things are structured in the backend, this may need some more thought put to it.