HHS / OPRE-OPS

ACF's OPRE OPS product. Code name Unicorn.
Other
12 stars 3 forks source link

OPS-2316/task-2465 - move old workflow notifications into status change requests #2467

Closed stevtek closed 3 months ago

stevtek commented 3 months ago

What changed

The moves the old workflow notifications into status change requests. There is more work to be done with notifications in other issues/PRs. Hard code DDs were removed so that it now just notifies the DD and Deputy DD to review based on the owning division.

Issue

2316

2465

fixes: #2134 see also #1471 for future work

How to test

run the tests Or run the app and request a status change and approve it and view the notifications

Definition of Done Checklist

stevtek commented 3 months ago

🤩 looks good Steve. Couple non-blocking observations. I know you mentioned there was more todo w/ notifications.

yes this is just porting them over as they were before, but they need more work