Closed jonnalley closed 23 hours ago
@johndeange it comes back as valid syntax in my local env but I see what you mean and yeah that parent object's existence isn't what I'm trying to achieve. I don't really want to test for the dev environment though because we don't want it visible for the azure dev environment either as you correctly stated. I switched it up to hopefully be more accurate although not statically built. Please re-review and let me know what you think. We're not doing anything else to distinguish in terms of local-dev vs. azure non-prod right now and given the priority of this, I thought this was an easy enough solution perhaps. 🤷
What changed
Given John's recent PR that ripped out the config for login.gov in azure and given that our
redirect_uri
on the login.gov side only works forlocalhost
anyway and not any hosted environment, I modified the conditional to only show the login.gov authn option when doing local dev. The intent is to create a better UX so that an unknowing user doesn't try to innocently auth with their login.gov sandbox account.However, this presumes that we don't set the environment variable to something for the non-static FE container build or for local, which seems to be the current practice for the time being.
Issue
N/A
How to test
Hit the front login page. For any azure non-prod environment, you should see only AMS or AMS plus FakeAuth. On localhost you should see all 3.