Change Validation on Agreement Filters

HHS / OPRE-OPS

ACF's OPRE OPS product. Code name Unicorn.

Other

12 stars 3 forks source link

Change Validation on Agreement Filters #2706

Closed kimschulke closed 2 weeks ago

kimschulke commented 2 weeks ago

Goals

Change the validation on agreement filters for procurement shop
right now, when a user clicks on the filters from the agreement list page, the UI is displaying a red error state on the procurement shop. For a better UX, we want to change the validation so it does not display an error by default, but only if/when the user tries to change the procurement shop from GCS to something else.

Tasks

[ ] change the validation on the filters so its not an error by default, only show an error if the user tries to change the procurement shop from GCS to something else

Additional Context

see screenshots below

kimschulke commented 2 weeks ago

this is what the filters look like when the user opens the filter options

kimschulke commented 2 weeks ago

I'm actually not sure if we need any validation at all here. We can just default to All and the agreements will only have GCS because we validate that at the create-agreement-level. If the user tries to filter by another procurement shop, they can do it, but there will be no results because all agreements will be using GCS.... thoughts?

fpigeonjr commented 2 weeks ago

Think our test data may have other-than-GCS procurement shops but will need to check. May be easier to just default to GCS and if user changes, than run validation checks.

fpigeonjr commented 2 weeks ago

I'm actually not sure if we need any validation at all here.

Yes I agree.

fpigeonjr commented 2 weeks ago

UX Review on 8/27/24

jonnalley commented 2 weeks ago

8/27