HHS / OPRE-OPS

ACF's OPRE OPS product. Code name Unicorn.

Other

12 stars 3 forks source link

fix: 🛠️ adds missing validation on Agreement form #2832

Closed fpigeonjr closed 1 month ago

fpigeonjr commented 2 months ago

What changed

adds missing Vest validation

Issue

2770

How to test

create min agreement
try to send to review
see validation errors
go to edit to fix errors
they should match
💰 profit

Screenshots

If relevant, e.g. for a front-end feature

Definition of Done Checklist

[X] OESA: Code refactored for clarity
[X] OESA: Dependency rules followed
[X] Automated unit tests updated and passed
[X] Automated integration tests updated and passed
[X] Automated quality tests updated and passed
[X] Automated load tests updated and passed
[X] Automated a11y tests updated and passed
[X] Automated security tests updated and passed
[X] 90%+ Code coverage achieved
[X] Form validations updated

jonnalley commented 2 months ago

Given this is a bug, is there an opportunity to update our tests?