[Issue #1886]: Fix duplicate id bug in SearchFilterAccordion - Githubissues

HHS / simpler-grants-gov

https://simpler.grants.gov

Other

42 stars 11 forks source link

[Issue #1886]: Fix duplicate id bug in SearchFilterAccordion #1924

Closed rylew1 closed 4 months ago

rylew1 commented 4 months ago

Summary

Fixes #1886

Time to review: 1 min

Changes proposed

add the query param key to the end of the accordion id

Context for reviewers

We had duplicate id's for each accordion div - so just append the specific query param key that we use to the id
the remaining Lighthouse a11y issue is due to the <span>...</span> that's in the component (only <li> tags are allowed inside <ul>) . But this is the USWDS implementation so I'm not sure if we can get around that bug?

Additional information

Lighthouse doesn't have this error anymore:

github-actions[bot] commented 4 months ago

Coverage report for `./frontend`

St.^{:grey_question:}	Category	Percentage	Covered / Total
🟢	Statements	83.89%	854/1018
🟡	Branches	64.9%	220/339
🟡	Functions	75.34%	165/219
🟢	Lines	83.89%	797/950

Test suite run success

166 tests passing in 55 suites.

Report generated by 🧪jest coverage report action from 06bacc01a71263aa017d3771873507ad7e45c87b