HHS / simpler-grants-gov

https://simpler.grants.gov
Other
44 stars 13 forks source link

[Task]: Fix race conditions between deploying dev and staging #2245

Closed coilysiren closed 1 month ago

coilysiren commented 1 month ago

Summary

This job failed because the image hadn't been publish when it was checked for staging. To fix this, we need to order deploys so that the environments deploy one at a time

Acceptance criteria

No response

coilysiren commented 1 month ago

The concurrency field should be handling this

https://github.com/HHS/simpler-grants-gov/blob/f9c11b3391900d6e8042dae3cfaf561c97f90d3c/.github/workflows/deploy.yml#L15

coilysiren commented 1 month ago

https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/running-variations-of-jobs-in-a-workflow#defining-the-maximum-number-of-concurrent-jobs