[no ticket] move drafts s3 bucket location

[coilysiren]

Summary

I really should have caught this in code review TBH ... but the s3 bucket needs to be defined inside of the module, because it uses variables only present inside of the module.

Context

https://github.com/HHS/simpler-grants-gov/actions/runs/11898376420/job/33154738145

Testing

  # module.service.aws_ecs_task_definition.app must be replaced
-/+ resource "aws_ecs_task_definition" "app" {
      ~ arn                      = "arn:aws:ecs:us-east-1:315341936575:task-definition/api-dev:272" -> (known after apply)
      ~ arn_without_revision     = "arn:aws:ecs:us-east-1:315341936575:task-definition/api-dev" -> (known after apply)
      ~ container_definitions    = jsonencode(
          ~ [
              ~ {
                  ~ environment            = [
                        # (5 unchanged elements hidden)
                        {
                            name  = "DB_USER"
                            value = "app"
                        },
                      + {
                          + name  = "DRAFTS_S3_BUCKET_ARN"
                          + value = "arn:aws:s3:::api-dev-documents-draft20241118182345535400000001"
                        },
                        {
                            name  = "ENVIRONMENT"
                            value = "dev"
                        },