Closed andycochran closed 9 months ago
I ran into one here I can't figure out how to fix: "Emphasize with not for with italicized text"
Adding <em>
tags to the content string requires that we use <Trans>
instead of t()
, or this happens:
I'm not sure how to best refactor the ProcessIntro
component to munge the {box.content}
.
cc @SammySteiner
This issue outlines miscellaneous changes required to 1) match the Figma mockup, and 2) improve responsive layout.
Home page
Use the domain for the Site title
✅ Fix: https://github.com/HHS/simpler-grants-gov/pull/896
Tighten the spacing on the Hero
✅ Fix: https://github.com/HHS/simpler-grants-gov/pull/897
desktop:margin-top-2
to the heading to decrease the space between it and the buttonline-height
of the intro paragraphdesktop:margin-bottom-0
to the intro paragraph to nix the extra space at bottom of HeroUpdate "The Goal" text
✅ Fix: https://github.com/HHS/simpler-grants-gov/pull/898
"The research" section missing dot in "Grants.gov"
✅ Fix: https://github.com/HHS/simpler-grants-gov/pull/899
This was a mistake in Figma, which has just been fixed.
Prevent the icon in buttons breaking to its own line
✅ Fix: https://github.com/HHS/simpler-grants-gov/pull/900
Simplify grid
✅ Fix: https://github.com/HHS/simpler-grants-gov/pull/902
Currently, the grid for "The goal" section goes from 6/6 on tablet, to 5/7 on desktop, to 6/6 on large desktop. There's no reason for that middle size to have a narrower lefthand column. The grid can just be 6/6 on tablet and above. Remove the
desktop:grid-col-5
anddesktop-lg:grid-col-6
classes.Process page
Emphasize with not for with italicized text
❌ Separate issue created: https://github.com/HHS/simpler-grants-gov/issues/909
Add
maxw-tablet-lg
to headers to improve legibility✅ Fix: https://github.com/HHS/simpler-grants-gov/pull/903
(Need to explore using
usa-prose
for this and other legibility improvements.)Update milestone 1 intro
✅ Fix: https://github.com/HHS/simpler-grants-gov/pull/904
(see above img)
Update milestone button links
❌ Separate issue created:https://github.com/HHS/simpler-grants-gov/issues/910
To confirm: We want to link directly to the specific 30Ks, not to the GitHub Projects board.
Bold links
✅ Fix: https://github.com/HHS/simpler-grants-gov/pull/911
Make the hyperlinked text bold so that it stands out from the paragraphs a bit more. (Ignore the lack of an external link icon in the mockup, that should be there as-is.)
Research page
"The research" intro missing dot in "Grants.gov"
✅ Fix: https://github.com/HHS/simpler-grants-gov/pull/899
This was a mistake in Figma, which has just been fixed.
Bold links at bottom of page
✅ Fix: https://github.com/HHS/simpler-grants-gov/pull/907
Make the hyperlinked text bold so that it stands out from the paragraphs a bit more.
Newsletter confirmation page
Bold links in "Learn more"
✅ Fix: https://github.com/HHS/simpler-grants-gov/pull/908