HHS / simpler-grants-pdf-builder

PDF builder that's used by the SimplerNOFOs project, part of the Simpler Grants initiative at HHS.
4 stars 1 forks source link

Remove stroke in CDC logo, add left padding to callout lists, manual CSS fixes for application table cells #19

Closed pcraig3 closed 2 weeks ago

pcraig3 commented 2 weeks ago

Summary

This PR does 3 things:

  1. removes stroke styling for the CDC logo.
  2. adds some left padding to callout box lists
  3. small CSS changes that let us manually fix application table checkbox lists

1. Remove stroke styling for the CDC logo.

I had added the stroke styling to fix what looked like a font rendering issue. But actually it was overcorrecting for a CSS rule that I didn't need, so now all the stroke rules are gone.

CDC default (blue)
before after
Screenshot 2024-10-28 at 4 53 19 PM Screenshot 2024-10-28 at 4 53 28 PM
CDC light (white)
before after
Screenshot 2024-10-28 at 4 54 02 PM Screenshot 2024-10-28 at 4 53 54 PM

2. adds left padding to callout box lists

I had previously removed the left padding on lists in callout boxes because we were trying to save space for those ones in the right column at the beginning of the NOFO. But for normal callout boxes, we don't need to do that.

before after
Screenshot 2024-10-28 at 6 19 00 PM Screenshot 2024-10-28 at 6 18 26 PM

3. Small CSS changes that allow manual fixes

This is kind of a weird one but it lets us to manually fix a tricky edge case we are running into with the application checklist table.

Why are we doing this?

Make the CDC NOFO look way better.

How to test this

It will just show up on CDC nofos.