search

HHSProgrammingClub / smash-my-buttons

Le all-purpose AI Fighting Game and possible eSport if everything goes better than expected lol
GNU General Public License v3.0
4 stars 1 forks source link

Set some classes to final #68

Closed jamesgol closed 5 years ago

jamesgol commented 5 years ago

I'm guessing you're all building in a different environment than I tried to. Using java-8-openjdk I had to set these to final in order to get it to run. Still some others that would need set but I wanted to see if I could get this to run at home since I won't be able to make it to your program at the library.

Cool project, wish we had the technology and a club doing cool stuff like this when I was in high school. Keep up the good work!

Edit: Don't feel like you have to deal with this if it's working in your environment, just wanted you to know someone else was interested in it

clman94 commented 5 years ago

Hmm, that's an odd one. We are currently using the Java SE development kit. Is there a major difference we are not fully aware of? Anyhow, it seems harmless enough to merge. Thanks for the contribution!

lgtyqz commented 5 years ago

Yeah, thanks for the unexpected attention! It's great to hear that full professionals are also interested in this thing we've made.