search

HHammond / PrettyPandas

A Pandas Styler class for making beautiful tables
http://prettypandas.readthedocs.org/
MIT License
415 stars 23 forks source link

Updated for Pandas 0.18, added optional thousands separator #34

Closed hottwaj closed 4 years ago

hottwaj commented 8 years ago

also removed deprecation warnings for as_money(), which is more flexible than the Babel as_currency() as precision and thousands separator can be controlled.

HHammond commented 8 years ago

I'm going to give this a look over and update tests for this today

hottwaj commented 8 years ago

Cool, thanks! I haven't allowed for different thousands separators (comma is assumed), and I think some places separate hundreds rather than thousands... I guess Babel might handle all of that, but not the precision issue...

All of the commits before 78d815c are from my other PR #31, but I didn't know how to isolate these changes... sorry! If I can do anything else let me know

HHammond commented 8 years ago

I need to give the Babel documentation another read anyways. It seemed to be breaking the ability to specify precision which I would like to fix.

hottwaj commented 4 years ago

I think you've since covered the pandas compatibility issue in master. Closing as the other stuff needs to be rebased. Thanks!