search

HHogg / remarkable-react

A configurable React component renderer for Remarkable.
MIT License
50 stars 8 forks source link

TokenTree is not extendable #21

Closed DxCx closed 6 years ago

DxCx commented 6 years ago

Hey,

TokenTree is not exported anywere, which means i cannot extend it and make my own implementation, can it be exported please?

HHogg commented 6 years ago

Hey @DxCx, yeah exporting it is not a problem. What part of the TokenTree are you after?

At the moment, the TokenTree is kind of tied to resolving token/props/components (which is configurable through the renderer API). If you're just after the part of transforming the remarkable token array into a tree structure, then it might be better if I expose this as a util function instead (so it doesn't come with all the other bits).

DxCx commented 6 years ago

This is exactly it, I am building a diff token type out of marked input So im calling my function if its the marked one or super (yours) if its not :)

DxCx commented 6 years ago

ping @HHogg ?

HHogg commented 6 years ago

Apologies @DxCx started a new job recently. Will try and take a look st this shortly.

DxCx commented 6 years ago

Thank you!

HHogg commented 6 years ago

@DxCx v1.4.0 now has the TokenTree exported. Give a shout here if there's any issues.

DxCx commented 6 years ago

alright! thanks alot :dancer: