HICAI-ZJU / iMoLD

Official implementation for Learning Invariant Molecular Representation in Latent Discrete Space (NeurIPS 2023)
MIT License
20 stars 2 forks source link

About Evaluation #5

Open AmingWu opened 3 months ago

AmingWu commented 3 months ago

Dear Authors,

I have finished the training process. However, I cannot find the saved model.

Is the model saved in dump/0813-ZINC/scaffold-concept/params.pkl?

But when I run the command, these exists an error, i.e., python eval.py --dataset GOODZINC --domain scaffold --shift concept --load_path dump/0813-ZINC/scaffold-concept/params.pkl?

捕获

toooooodo commented 3 months ago

Hi, it seems that you have specified incorrect load_path, the correct path should be as specified in https://github.com/HICAI-ZJU/iMoLD/blob/6d244521a19a6e4a6ef7e4a2356cc29ab1cf9917/exputils.py#L165

AmingWu commented 3 months ago

During training, should I set --load_path ?

toooooodo commented 3 months ago

This is not required. This parameter is only needed for eval.py, and we provide the trained model in the release page.

AmingWu commented 3 months ago

Now, I want to re-train this code. I set the save_dir to 'checkpoint/'. Is it right?

AmingWu commented 3 months ago

Dear Authors,

When I finish the training, i.e., python run.py --dataset GOODZINC --domain scaffold --shift concept --num_e 4000 --bs 256 --gamma 0.5 --inv_w 0.01 --reg_w 0.5 --gpu 1 --exp_name ZINC --exp_id scaffold-concept

I still could not finish evaluation successfully.

AmingWu commented 3 months ago

Could you tell me where the trained model is? I use the default path.

toooooodo commented 3 months ago

Hello, I checked the code and found that the model was not being saved during training. You can call https://github.com/HICAI-ZJU/iMoLD/blob/6d244521a19a6e4a6ef7e4a2356cc29ab1cf9917/exputils.py#L165 in train.py to save the model.